fix!: Updates expiration paramater in presign functions to TimeInterval type.
#805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will regenerate models after this is merged. |
jbelkins
approved these changes
Jan 5, 2023
ganeshnj
approved these changes
Jan 5, 2023
ganeshnj
reviewed
Jan 5, 2023
...tware/amazon/smithy/aws/swift/codegen/customization/presignable/PresignableUrlIntegration.kt
Outdated
Show resolved
Hide resolved
ganeshnj
suggested changes
Jan 5, 2023
...-codegen/src/test/kotlin/software/amazon/smithy/aws/swift/codegen/PresignerGeneratorTests.kt
Outdated
Show resolved
Hide resolved
epau
force-pushed
the
epau/fix/crt-breaking-changes
branch
from
7a46af8
to
616a3b8
Compare
ganeshnj
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the upgrade to CRT 0.5.0+, the type of expiration changed from Int64 to TimeInterval.
Therefore, services that define presign functions (such as S3) fail to build because of the type mistmatch.
IMO it makes sense to update the type exposed in the functions to TimeInterval since TimeInterval is a better way to describe a value that should be in seconds.
Issue #
#804
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.